Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(takeUntil): no longer subscribes to source if notifier synchrono… #3504

Merged
merged 1 commit into from
Mar 30, 2018

Conversation

benlesh
Copy link
Member

@benlesh benlesh commented Mar 30, 2018

…usly emits

closes #2189

cc @trxcllnt

@benlesh benlesh requested a review from trxcllnt March 30, 2018 20:40
@benlesh
Copy link
Member Author

benlesh commented Mar 30, 2018

Given that this is a copy of #2189, which is already reviewed, I'm going to merge it once it's green.

@benlesh benlesh merged commit 7b8a3e3 into ReactiveX:master Mar 30, 2018
@benlesh benlesh removed the request for review from trxcllnt March 30, 2018 20:48
@lock
Copy link

lock bot commented Jun 5, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant